[ https://issues.apache.org/jira/browse/HBASE-20781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523093#comment-16523093 ]
Duo Zhang commented on HBASE-20781: ----------------------------------- The approach is fine. +1. But seems we broke some UTs? > Save recalculating families in a WALEdit batch of Cells > ------------------------------------------------------- > > Key: HBASE-20781 > URL: https://issues.apache.org/jira/browse/HBASE-20781 > Project: HBase > Issue Type: Sub-task > Components: Performance > Reporter: stack > Assignee: stack > Priority: Major > Attachments: 2.0621.2.12782.cpu.svg, 2.0621.256k.51351.cpu.svg, > 2.0623.families.121250.cpu.svg, HBASE-20781.branch-2.0.001.patch, > HBASE-20781.master.001.patch > > > Doing a doMiniBatchMutate, we calculate the set of families that the WALEdit > Cells belong to up front but down after the RingBuffer when we make an > FSWALEdit, we spin through all the Cells again to figure the set of families > in a particularly painful way. Just pass the calculated family set in the > WALEdit. -- This message was sent by Atlassian JIRA (v7.6.3#76005)