[ 
https://issues.apache.org/jira/browse/HBASE-20795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524577#comment-16524577
 ] 

Hudson commented on HBASE-20795:
--------------------------------

Results for branch branch-2.0
        [build #478 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/478/]: 
(x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/478//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/478//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/478//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Allow option in BBKVComparator.compare to do comparison without sequence id
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-20795
>                 URL: https://issues.apache.org/jira/browse/HBASE-20795
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.1
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Major
>             Fix For: 3.0.0, 2.1.0, 2.0.2
>
>         Attachments: HBASE-20795.patch
>
>
> CellComparatorImpl#compare(final Cell a, final Cell b, boolean 
> ignoreSequenceid) needs to ignore sequence id in comparison if 
> ignoreSequenceId parameter is set to true but BBKVComparator.compare used 
> internally for the cell of type ByteBufferKeyValue doesn't consider this.
>  {code}
> @Override
>   public int compare(final Cell a, final Cell b, boolean ignoreSequenceid) {
>     int diff = 0;
>     // "Peel off" the most common path.
>     if (a instanceof ByteBufferKeyValue && b instanceof ByteBufferKeyValue) {
>       diff = BBKVComparator.compare((ByteBufferKeyValue)a, 
> (ByteBufferKeyValue)b);
>       if (diff != 0) {
>         return diff;
>       }
>     } else {
>       diff = compareRows(a, b);
>       if (diff != 0) {
>         return diff;
>       }
>       diff = compareWithoutRow(a, b);
>       if (diff != 0) {
>         return diff;
>       }
>     }
>     // Negate following comparisons so later edits show up first mvccVersion: 
> later sorts first
>     return ignoreSequenceid? diff: Long.compare(b.getSequenceId(), 
> a.getSequenceId());
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to