[ 
https://issues.apache.org/jira/browse/HBASE-20789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526844#comment-16526844
 ] 

Zach York commented on HBASE-20789:
-----------------------------------

[~openinx]
{quote}bq. If the existingBlock has nextBlockOnDiskSize set , while cachedItem 
has nextBlockOnDiskSize(default = -1) unset, the comparison should be positive 
number ? 
 So there is a typo ?
{quote}
No, cachedItem will be smaller in that case and so the comparison will be -1. I 
think this is why you were having difficulty getting the tests to pass. Please 
flip the '>' back to a '<'

> TestBucketCache#testCacheBlockNextBlockMetadataMissing is flaky
> ---------------------------------------------------------------
>
>                 Key: HBASE-20789
>                 URL: https://issues.apache.org/jira/browse/HBASE-20789
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>            Priority: Major
>             Fix For: 3.0.0, 2.1.0, 1.5.0, 1.4.6, 2.0.2
>
>         Attachments: 
> 0001-HBASE-20789-TestBucketCache-testCacheBlockNextBlockM.patch, 
> HBASE-20789.v1.patch, HBASE-20789.v2.patch, bucket-33718.out
>
>
> The UT failed frequently in our internal branch-2... Will dig into the UT.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to