[ 
https://issues.apache.org/jira/browse/HBASE-20826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528202#comment-16528202
 ] 

Josh Elser commented on HBASE-20826:
------------------------------------

{quote}Maybe the LOG.isTraceEnabled() check can be removed. Otherwise log file 
would be filled fast in TRACE mode.
{quote}
My thinking was that we want the full TRACE for cases when we want to know 
exactly what is happening. Could change this to be much longer (e.g. 1000 
chars) if TRACE is enabled?

> Truncate responseInfo attributes on RpcServer WARN messages
> -----------------------------------------------------------
>
>                 Key: HBASE-20826
>                 URL: https://issues.apache.org/jira/browse/HBASE-20826
>             Project: HBase
>          Issue Type: Improvement
>          Components: rpc
>            Reporter: Sergey Soldatov
>            Assignee: Josh Elser
>            Priority: Major
>             Fix For: 3.0.0, 2.1.0, 2.0.2, 2.2.0
>
>         Attachments: HBASE-20826.001.branch-2.0.patch
>
>
> With Phoenix in the picture, dumping the {{Call}} protobuf to the RS log can 
> get *really* chatty, real fast. Notably, some serialized filters just spam 
> the log with binary garbage.
> Let's add an upper-limit to the length of params we'll put out at WARN, and 
> leave the full content for TRACE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to