[ https://issues.apache.org/jira/browse/HBASE-20837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530513#comment-16530513 ]
Tak Lon (Stephen) Wu commented on HBASE-20837: ---------------------------------------------- I'm working on the IDE part in eclipse format, will update the patch once I have it. but the importOrder in the checkstyle woule be like this {code:java} <!-- Import Checks http://checkstyle.sourceforge.net/config_imports.html --> <module name="AvoidStarImport"/> <module name="ImportOrder"> <property name="groups" value="*,/^java\./,javax,org.apache.hbase.thirdparty,org.apache.hadoop.hbase.shaded"/> <property name="option" value="top" /> <property name="ordered" value="true"/> <property name="sortStaticImportsAlphabetically" value="true"/> </module> <module name="RedundantImport"/> <module name="UnusedImports"> <property name="processJavadoc" value="true"/> </module>{code} > Sync import orders between IDE and checkstyle module > ---------------------------------------------------- > > Key: HBASE-20837 > URL: https://issues.apache.org/jira/browse/HBASE-20837 > Project: HBase > Issue Type: Task > Affects Versions: 3.0.0, 2.0.1, 1.4.5 > Reporter: Tak Lon (Stephen) Wu > Priority: Major > Attachments: image-2018-07-02-15-27-41-140.png > > > While working on HBASE-20557 contribution, we figured out that the checkstyle > build target (ImportOrder's `groups` > [http://checkstyle.sourceforge.net/config_imports.html] ) was different from > the development supported IDE formatter, we would provide a fix here to sync > between > [dev-support/hbase_eclipse_formatter.xml|https://github.com/apache/hbase/blob/master/dev-support/hbase_eclipse_formatter.xml] > and > [hbase/checkstyle.xml|https://github.com/apache/hbase/blob/master/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml] > This might need to backport the changes of master to branch-1 and branch-2 as > well. > Before this change, this is what checkstyle is expecting for import order > > {code:java} > import com.google.common.annotations.VisibleForTesting; > import java.io.IOException; > import java.util.ArrayList; > import java.util.List; > import java.util.Map; > import org.apache.commons.logging.Log; > import org.apache.commons.logging.LogFactory; > import org.apache.hadoop.conf.Configuration; > import org.apache.hadoop.hbase.classification.InterfaceAudience; > import org.apache.hadoop.hbase.conf.ConfigurationObserver;{code} > > And the proposed import order with the respect to HBASE-19262 and HBASE-19552 > should be > !image-2018-07-02-15-27-41-140.png! > -- This message was sent by Atlassian JIRA (v7.6.3#76005)