[
https://issues.apache.org/jira/browse/HBASE-20808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532953#comment-16532953
]
Nihal Jain commented on HBASE-20808:
------------------------------------
{quote}Let's do some more cleaning if you would like to.
{quote}
Would love to! Anyways, it always feels good to see cleaner code. :)
{quote}Here's the snippet after modification, method
HMaster#cancelChore(ScheduledChore) are redundant codes
{quote}
How about this?
{code:java}
private void stopChores() {
ChoreService choreService = getChoreService();
choreService.cancelChore(this.expiredMobFileCleanerChore);
choreService.cancelChore(this.mobCompactChore);
. . .
choreService.cancelChore(this.replicationBarrierCleaner);
if (this.mobCompactThread != null) {
this.mobCompactThread.close();
}
}
{code}
> Wrong shutdown order between Chores and ChoreService
> ----------------------------------------------------
>
> Key: HBASE-20808
> URL: https://issues.apache.org/jira/browse/HBASE-20808
> Project: HBase
> Issue Type: Bug
> Reporter: Reid Chan
> Assignee: Nihal Jain
> Priority: Minor
> Labels: beginner
> Attachments: HBASE-20808.master.001.patch,
> HBASE-20808.master.002.patch, HBASE-20808.master.003.patch
>
>
> When stopping master, {{ChoreService}}, which serves all the chores, is
> stopped before canceling all running chores.
> It should cancel all running chores, then shutdown {{ChoreService}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
