[ https://issues.apache.org/jira/browse/HBASE-20837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537926#comment-16537926 ]
Hadoop QA commented on HBASE-20837: ----------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} branch-2 Compile Tests {color} || || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 0m 52s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:42ca976 | | JIRA Issue | HBASE-20837 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12930936/HBASE-20837.branch-2.003.patch | | Optional Tests | asflicense xml | | uname | Linux eecba3dba5ca 4.4.0-130-generic #156-Ubuntu SMP Thu Jun 14 08:53:28 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-2 / 8decae9b92 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Max. process+thread count | 48 (vs. ulimit of 10000) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/13560/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > Make IDE configuration for import order match that in our checkstyle module > --------------------------------------------------------------------------- > > Key: HBASE-20837 > URL: https://issues.apache.org/jira/browse/HBASE-20837 > Project: HBase > Issue Type: Improvement > Components: community > Affects Versions: 3.0.0, 2.0.1, 1.4.5 > Reporter: Tak Lon (Stephen) Wu > Assignee: Tak Lon (Stephen) Wu > Priority: Minor > Fix For: 3.0.0, 1.5.0, 2.2.0 > > Attachments: HBASE-20837.branch-1.001.patch, > HBASE-20837.branch-1.002.patch, HBASE-20837.branch-1.003.patch, > HBASE-20837.branch-2.001.patch, HBASE-20837.branch-2.002.patch, > HBASE-20837.branch-2.003.patch, HBASE-20837.master.001.patch, > HBASE-20837.master.002.patch, HBASE-20837.master.003.patch, IDEA import > layout.png, hbase-intellij-formatter.xml > > > While working on HBASE-20557 contribution, we figured out that the checkstyle > build target (ImportOrder's `groups` > [http://checkstyle.sourceforge.net/config_imports.html] ) was different from > the development supported IDE (e.g. IntelliJ and Eclipse) formatter, we would > provide a fix here to sync between > [dev-support/hbase_eclipse_formatter.xml|https://github.com/apache/hbase/blob/master/dev-support/hbase_eclipse_formatter.xml] > and > [hbase/checkstyle.xml|https://github.com/apache/hbase/blob/master/hbase-checkstyle/src/main/resources/hbase/checkstyle.xml] > This might need to backport the changes of master to branch-1 and branch-2 as > well. > Before this change, this is what checkstyle is expecting for import order > > {code:java} > import com.google.common.annotations.VisibleForTesting; > import java.io.IOException; > import java.util.ArrayList; > import java.util.List; > import java.util.Map; > import org.apache.commons.logging.Log; > import org.apache.commons.logging.LogFactory; > import org.apache.hadoop.conf.Configuration; > import org.apache.hadoop.hbase.classification.InterfaceAudience; > import org.apache.hadoop.hbase.conf.ConfigurationObserver;{code} > > And the proposed import order with the respect to HBASE-19262 and HBASE-19552 > should be > > !IDEA import layout.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)