[
https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544557#comment-16544557
]
Kuan-Po Tseng commented on HBASE-18201:
---------------------------------------
Patch 004
Bugs
* When HFile includeTags is true, it does'nt mean all Cells in HFile contains
tags, those don't contains tags will have a tagsLen((short) 0) part after the
KeyValue structure. During the decoding process, decoder ROW_INDEX_V1 will not
put tagsLen part back in cell if it is zero.
Tests
* Add DataBlockEncodingTool testing for HFile with cells contasin tags or not.
Others
* Fix some coding style problems.
> add UT and docs for DataBlockEncodingTool
> -----------------------------------------
>
> Key: HBASE-18201
> URL: https://issues.apache.org/jira/browse/HBASE-18201
> Project: HBase
> Issue Type: Sub-task
> Components: tooling
> Reporter: Chia-Ping Tsai
> Assignee: Kuan-Po Tseng
> Priority: Minor
> Labels: beginner
> Attachments: HBASE-18201.master.001.patch,
> HBASE-18201.master.002.patch, HBASE-18201.master.002.patch,
> HBASE-18201.master.003.patch, HBASE-18201.master.004.patch
>
>
> There is no example, documents, or tests for DataBlockEncodingTool. We should
> have it friendly if any use case exists. Otherwise, we should just get rid of
> it because DataBlockEncodingTool presumes that the implementation of cell
> returned from DataBlockEncoder is KeyValue. The presume may obstruct the
> cleanup of KeyValue references in the code base of read/write path.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
