[ https://issues.apache.org/jira/browse/HBASE-20411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546503#comment-16546503 ]
Yu Li edited comment on HBASE-20411 at 7/17/18 12:11 PM: --------------------------------------------------------- Noticed when checking 2.1.0RC1 compatibility report, that in this JIRA we have changed the visibility of {{MemStoreSize#constructors}} from public to package-private. Since {{MemStoreSize}} is not marked as IS.Evolving, and in our [refguide matrix|http://hbase.apache.org/book.html#hbase.versioning] we have below content, are we breaking the compatibility here? Or could you help correct my understanding here boss [~stack]? Thanks. !compatibility-matrix.png! was (Author: carp84): Noticed when checking 2.1.0RC1 compatibility report, that in this JIRA we have changed the visibility of {{MemStoreSize#constructors}} from public to package-private. Since {{MemStoreSize}} is not marked as IS.Evolving, and in our [refguide matrix|http://hbase.apache.org/book.html#hbase.versioning] we have below content: !compatibility-matrix.png! > Ameliorate MutableSegment synchronize > ------------------------------------- > > Key: HBASE-20411 > URL: https://issues.apache.org/jira/browse/HBASE-20411 > Project: HBase > Issue Type: Bug > Reporter: stack > Assignee: huaxiang sun > Priority: Major > Fix For: 2.0.1 > > Attachments: 2.load.patched.17704.lock.svg, > 2.load.patched.2.17704.lock.svg, 2.more.patch.12010.lock.svg, > 2.pe.write.32026.lock.svg, 2.pe.write.ameliorate.106553.lock.svg, > 41901.lock.svg, HBASE-20411-atomiclong-longadder.patch, > HBASE-20411.branch-2.0.001.patch, HBASE-20411.branch-2.0.002.patch, > HBASE-20411.branch-2.0.003.patch, HBASE-20411.branch-2.0.004.patch, > HBASE-20411.branch-2.0.005.patch, HBASE-20411.branch-2.0.006.patch, > HBASE-20411.branch-2.0.007.patch, HBASE-20411.branch-2.0.008.patch, > HBASE-20411.branch-2.0.009.patch, HBASE-20411.branch-2.0.010.patch, > HBASE-20411.branch-2.0.011.patch, HBASE-20411.branch-2.0.012.patch, > HBASE-20411.branch-2.0.013.patch, compatibility-matrix.png, > jmc6.write_time_locks.png > > > This item is migrated from HBASE-20236 so it gets dedicated issue. > Let me upload evidence that has this synchronize as a stake in our write-time > perf. I'll migrate the patch I posted with updates that come of comments > posted by [~mdrob] on the HBASE-20236 issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)