Ted Yu created HBASE-20917: ------------------------------ Summary: MetaTableMetrics#stop references uninitialized requestsMap for non-meta region Key: HBASE-20917 URL: https://issues.apache.org/jira/browse/HBASE-20917 Project: HBase Issue Type: Bug Reporter: Ted Yu
I noticed the following in test output: {code} 2018-07-21 15:54:43,181 ERROR [RS_CLOSE_REGION-regionserver/172.17.5.4:0-1] executor.EventHandler(186): Caught throwable while processing event M_RS_CLOSE_REGION java.lang.NullPointerException at org.apache.hadoop.hbase.coprocessor.MetaTableMetrics.stop(MetaTableMetrics.java:329) at org.apache.hadoop.hbase.coprocessor.BaseEnvironment.shutdown(BaseEnvironment.java:91) at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionEnvironment.shutdown(RegionCoprocessorHost.java:165) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.shutdown(CoprocessorHost.java:290) at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$4.postEnvCall(RegionCoprocessorHost.java:559) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:622) at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postClose(RegionCoprocessorHost.java:551) at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1678) at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1484) at org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:104) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) {code} {{requestsMap}} is only initialized for the meta region. However, check for meta region is absent in the stop method: {code} public void stop(CoprocessorEnvironment e) throws IOException { // since meta region can move around, clear stale metrics when stop. for (String meterName : requestsMap.keySet()) { {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)