[ 
https://issues.apache.org/jira/browse/HBASE-20929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554444#comment-16554444
 ] 

Josh Elser commented on HBASE-20929:
------------------------------------

[~vishk], would be better to switch this over to SLF4j API and use the {{{}}} 
replacement markers to avoid the extra if-clause.

You planning to work on this?

> IncreasingToUpperBoundRegionSplitPolicy -> shouldSplit -> Log.debug should be 
> enclosed inside LOG.isdebugEnabled()
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-20929
>                 URL: https://issues.apache.org/jira/browse/HBASE-20929
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Vishal Khandelwal
>            Assignee: Vishal Khandelwal
>            Priority: Minor
>
> Class IncreasingToUpperBoundRegionSplitPolicy. 
>  
> if (size > sizeToCheck) {
>  LOG.debug("ShouldSplit because " + store.getColumnFamilyName() + " size=" + 
> size
>  + ", sizeToCheck=" + sizeToCheck + ", regionsWithCommonTable="
>  + tableRegionsCount);
>  foundABigStore = true;
>  }
>  
> LOG.debug("Failed getOnlineRegions " + tablename, e);



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to