[ https://issues.apache.org/jira/browse/HBASE-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554487#comment-16554487 ]
Xu Cang edited comment on HBASE-9888 at 7/24/18 4:29 PM: --------------------------------------------------------- {code:java} conf1.setBoolean("hbase.replication.walKeyWriteTime.filter.enabled", false);{code} I see you only test the case that filter.enabled is false. Where is the test when "filter.enabled" is true? Sorry if I am misreading it. thanks. {code:java} + assertTrue("table data should be deleted from source", utility1.countRows(htable1) == 1); {code} Message typo? should be "added" instead of "deleted"? {code:java} + System.out.println("Rows still not available in peer table"); Log instead of system.out?{code} was (Author: xucang): {code:java} conf1.setBoolean("hbase.replication.walKeyWriteTime.filter.enabled", false);{code} I see you only test the case that filter.enabled is false. Where is the test when "filter.enabled" is true? Sorry if I am misreading it. thanks. {code:java} + assertTrue("table data should be deleted from source", utility1.countRows(htable1) == 1); {code} > HBase replicates edits written before the replication peer is created > --------------------------------------------------------------------- > > Key: HBASE-9888 > URL: https://issues.apache.org/jira/browse/HBASE-9888 > Project: HBase > Issue Type: Bug > Affects Versions: 1.5.0 > Reporter: Dave Latham > Priority: Major > Attachments: HBASE-9888.branch-1.001.patch > > > When creating a new replication peer the ReplicationSourceManager enqueues > the currently open HLog to the ReplicationSource to ship to the destination > cluster. The ReplicationSource starts at the beginning of the HLog and ships > over any pre-existing writes. > A workaround is to roll all the HLogs before enabling replication. > A little background for how it affected us - we were migrating one cluster in > a master-master pair. I.e. transitioning from A <\-> B to B <-> C. After > shutting down writes from A -> B we enabled writes from C -> B. However, > this replicated some earlier writes that were in C's HLogs that had > originated in A. Since we were running a version of HBase before HBASE-7709 > those writes then got caught in a infinite replication cycle and bringing > down region servers OOM because of HBASE-9865. > However, in general, if one wants to manage what data gets replicated, one > wouldn't expect that potentially very old writes would be included when > setting up a new replication link. -- This message was sent by Atlassian JIRA (v7.6.3#76005)