[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559368#comment-16559368 ]
Zach York commented on HBASE-20734: ----------------------------------- {quote}I don't seem to find the code where, if recovered edits dir is not found under walFs, we should look under region dir. {quote} Responding to this comment here as others might want to weigh in. I have some concerns adding an additional check (and FS operation) every time the Region is opened, recovered, etc. At the same time I don't want to lose any recovered edits that were put under the root dir. I've been thinking about this a lot and I don't have a solution that I like yet. I've thought about conditionally controlling this check via config value, adding a separate tool/script to run that will migrate the any recovered edits under the root dir to the custom wal dir, etc. If people think that adding this check every time a Region tries to recover any edits won't add overhead, then I'll implement it, but I'm wary of doing that because I can't see a time when we'll be able to remove this code path (the code path should be effective at most once per region and after that it is just wasted time). What do some of the others watching this Jira think about this? > Colocate recovered edits directory with hbase.wal.dir > ----------------------------------------------------- > > Key: HBASE-20734 > URL: https://issues.apache.org/jira/browse/HBASE-20734 > Project: HBase > Issue Type: Improvement > Components: MTTR, Recovery, wal > Reporter: Ted Yu > Assignee: Zach York > Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20734.branch-1.001.patch > > > During investigation of HBASE-20723, I realized that we wouldn't get the best > performance when hbase.wal.dir is configured to be on different (fast) media > than hbase rootdir w.r.t. recovered edits since recovered edits directory is > currently under rootdir. > Such setup may not result in fast recovery when there is region server > failover. > This issue is to find proper (hopefully backward compatible) way in > colocating recovered edits directory with hbase.wal.dir . -- This message was sent by Atlassian JIRA (v7.6.3#76005)