[
https://issues.apache.org/jira/browse/HBASE-19369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560110#comment-16560110
]
Ted Yu commented on HBASE-19369:
--------------------------------
Looks good overall.
{code}
+ } catch (NoSuchMethodException e) {
+ LOG.debug("Could not find method on builder; will use old DFS API
for file creation", e);
{code}
Since the absence of the method(s) is logged at DEBUG level, there is no need
to include the full stack trace of the exception. Exception message should be
good enough.
{code}
+ } else {
+ return fs.createNonRecursive(path, overwritable, bufferSize,
replication, blockSize, null);
{code}
nit: the 'else' is not needed.
{code}
+public class TestHBaseOnEC {
{code}
There might be more tests added for hadoop with EC enabled. This test is for
WAL.
Please consider adding WAL to the class name.
> HBase Should use Builder Pattern to Create Log Files while using WAL on
> Erasure Coding
> --------------------------------------------------------------------------------------
>
> Key: HBASE-19369
> URL: https://issues.apache.org/jira/browse/HBASE-19369
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Alex Leblang
> Assignee: Mike Drob
> Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-19369.master.001.patch,
> HBASE-19369.master.002.patch, HBASE-19369.master.003.patch,
> HBASE-19369.master.004.patch, HBASE-19369.v10.patch, HBASE-19369.v11.patch,
> HBASE-19369.v12.patch, HBASE-19369.v5.patch, HBASE-19369.v6.patch,
> HBASE-19369.v7.patch, HBASE-19369.v8.patch, HBASE-19369.v9.patch
>
>
> Right now an HBase instance using the WAL won't function properly in an
> Erasure Coded environment. We should change the following line to use the
> hdfs.DistributedFileSystem builder pattern
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java#L92
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
