[
https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217647#comment-13217647
]
jirapos...@reviews.apache.org commented on HBASE-5443:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5364
-----------------------------------------------------------
here are some initial thoughts, let's make sure we get good discussion on this
before commit.
src/main/proto/HRegionProtocol.proto
<https://reviews.apache.org/r/4054/#comment11671>
I think we could collapse Put and Delete
src/main/proto/HRegionProtocol.proto
<https://reviews.apache.org/r/4054/#comment11672>
typo
src/main/proto/HRegionProtocol.proto
<https://reviews.apache.org/r/4054/#comment11673>
we seem to be missing a row here.
src/main/proto/HRegionProtocol.proto
<https://reviews.apache.org/r/4054/#comment11674>
Why are the HLog-related things under HRegionProtocol? Seems like these
shouldn't be exposed to clients.
src/main/proto/HRegionProtocol.proto
<https://reviews.apache.org/r/4054/#comment11675>
would be nice to extract these "management interface" things from this
protocol -- so the stuff that the average client needs goes in one place, and
the stuff that only management tools would use go in another.
src/main/proto/HRegionProtocol.proto
<https://reviews.apache.org/r/4054/#comment11676>
Also these calls which are supposed to only be called by the master, maybe
we can move elsewhere
src/main/proto/HRegionProtocol.proto
<https://reviews.apache.org/r/4054/#comment11677>
Can this be collapsed with CloseRegion?
Maybe we can have a proto like:
message RegionSpecifierProto {
required RegionSpecifierType type = 1;
required bytes data = 2;
enum RegionSpecifierType {
BY_REGION_ID_SHA1=0,
BY_CONTAINED_ROW=1,
BY_FULL_NAME=2
}
}
or something? Seems like it would be useful throughout to refer to regions
in places where it's nice to have flexibility
src/main/proto/HRegionProtocol.proto
<https://reviews.apache.org/r/4054/#comment11678>
why do we need a regioninfo here? we can locate the region by its split
point, can't we?
src/main/proto/hbase.proto
<https://reviews.apache.org/r/4054/#comment11680>
isn't the regionName just the concatenation of other fields here?
src/main/proto/hbase.proto
<https://reviews.apache.org/r/4054/#comment11679>
these two don't seem to belong here, since they're transient *state* rather
than properties of the region itself
src/main/proto/hbase.proto
<https://reviews.apache.org/r/4054/#comment11681>
when do you set allTime? isn't "allTime" the same as setting both of the
above to null?
- Todd
On 2012-02-27 18:54:31, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4054/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-27 18:54:31)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the first draft of the ProtoBuff HRegionProtocol. The
corresponding java vs pb method mapping is attached to the jira:
https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq. Please review. I'd like to move ahead after we get to some agreement.
bq.
bq.
bq. This addresses bug HBASE-5443.
bq. https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml 066c027
bq. src/main/proto/HRegionProtocol.proto PRE-CREATION
bq. src/main/proto/hbase.proto PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4054/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Add PB-based calls to HRegionInterface
> --------------------------------------
>
> Key: HBASE-5443
> URL: https://issues.apache.org/jira/browse/HBASE-5443
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Todd Lipcon
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: region_java-proto-mapping.pdf
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
