[
https://issues.apache.org/jira/browse/HBASE-20896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564732#comment-16564732
]
Vikas Vishwakarma commented on HBASE-20896:
-------------------------------------------
[~reidchan] I have addressed all the review comments. Changed LinkedList to
List in ScanResultCache and the inheritances
Removed the code repetition by adding a constructor and calling super(cache) in
the inheritances, same for clear();
changed access modifiers to default for newly added variables in ScanResultCache
replaced count = 0 and resultSize = 0 with call to corresponding reset functions
Thanks for the detailed review, kindly take a look at the latest patch updated
in the Jira and ReviewBoard
(fixed the whitespace warnings from Hadoop QA in the latest patch)
> Port HBASE-20866 to branch-1 and branch-1.4
> --------------------------------------------
>
> Key: HBASE-20896
> URL: https://issues.apache.org/jira/browse/HBASE-20896
> Project: HBase
> Issue Type: Sub-task
> Reporter: Andrew Purtell
> Assignee: Vikas Vishwakarma
> Priority: Major
> Fix For: 1.5.0, 1.4.7
>
> Attachments: HBASE-20896.branch-1.4.001.patch,
> HBASE-20896.branch-1.4.002.patch, HBASE-20896.branch-1.4.003.patch,
> HBASE-20896.branch-1.4.004.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
