[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570012#comment-16570012 ]
Ted Yu commented on HBASE-19008: -------------------------------- Please fix the following compilation errors: {code} [ERROR] /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java:[413,24] [ArrayHashCode] hashcode method on array does not hash array contents (see http://errorprone.info/bugpattern/ArrayHashCode) Did you mean 'return Objects.hash(this.prevFilterRCList,this.prevCellList,Arrays.hashCode(this.filters.toArray()));'? [ERROR] /testptch/hbase/hbase-spark/src/main/java/org/apache/hadoop/hbase/spark/SparkSQLPushDownFilter.java:[307,33] [ArrayHashCode] hashcode method on array does not hash array contents (see http://errorprone.info/bugpattern/ArrayHashCode) Did you mean 'hash=hash+Arrays.hashCode(val);'? {code} Please also address findbugs and checkstyle warnings. > Add missing equals or hashCode method(s) to stock Filter implementations > ------------------------------------------------------------------------ > > Key: HBASE-19008 > URL: https://issues.apache.org/jira/browse/HBASE-19008 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: liubangchen > Priority: Major > Labels: filter > Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-2.patch, > HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, > HBASE-19008.patch > > > In HBASE-15410, [~mdrob] reminded me that Filter implementations may not > write {{equals}} or {{hashCode}} method(s). > This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock > Filter implementations such as KeyOnlyFilter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)