[ https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570978#comment-16570978 ]
huaxiang sun commented on HBASE-20943: -------------------------------------- Hi [~jinghanx], the patch looks good. One nit, can getOnlineRegions/offlineRegion be merged into one method, return PairOfSameType<Integer> so it can save some cycles? > Add offline/online region count into metrics > -------------------------------------------- > > Key: HBASE-20943 > URL: https://issues.apache.org/jira/browse/HBASE-20943 > Project: HBase > Issue Type: Improvement > Components: metrics > Affects Versions: 2.0.0, 1.2.6.1 > Reporter: Tianying Chang > Assignee: jinghan xu > Priority: Minor > Attachments: HBASE-20943.patch, Screen Shot 2018-07-25 at 2.51.19 > PM.png > > > We intensively use metrics to monitor the health of our HBase production > cluster. We have seen some regions of a table stuck and cannot be brought > online due to AWS issue which cause some log file corrupted. It will be good > if we can catch this early. Although WebUI has this information, it is not > useful for automated monitoring. By adding this metric, we can easily monitor > them with our monitoring system. -- This message was sent by Atlassian JIRA (v7.6.3#76005)