[
https://issues.apache.org/jira/browse/HBASE-21002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572067#comment-16572067
]
ASF GitHub Bot commented on HBASE-21002:
----------------------------------------
joshelser commented on a change in pull request #1: HBASE-21002 Reorganize the
Kafka Connector codebase
URL: https://github.com/apache/hbase-connectors/pull/1#discussion_r208331094
##########
File path: pom.xml
##########
@@ -18,15 +18,6 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
Review comment:
Yup. Defining the module as `path/to/the/real_module_name` works just fine
in the parent pom, and then in the `real_module_name` pom.xml, we just unwind
the `relativePath` to the parent. Can also undo this if you think it's
unnecessary. I thought this would be nice once we have `kafka`, `rest`,
`thrift1`, `thrift2`, etc as top-level directories.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create assembly and scripts to start Kafka Proxy
> ------------------------------------------------
>
> Key: HBASE-21002
> URL: https://issues.apache.org/jira/browse/HBASE-21002
> Project: HBase
> Issue Type: Sub-task
> Components: hbase-connectors
> Reporter: Mike Wingert
> Assignee: Mike Wingert
> Priority: Minor
>
> Add scripts for running and assembly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
