[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219710#comment-13219710 ]
honghua zhu commented on HBASE-5491: ------------------------------------ @stack Well, you are right. :) I do not understand the original author why introduced the conf field to Exec class, Exec extends org.apache.hadoop.hbase.ipc.Invocation where has a conf field too. I think that the new Exec(HBaseConfiguration.create()) is not necessary. > Remove HBaseConfiguration.create() call from coprocessor.Exec class > ------------------------------------------------------------------- > > Key: HBASE-5491 > URL: https://issues.apache.org/jira/browse/HBASE-5491 > Project: HBase > Issue Type: Improvement > Components: coprocessors > Affects Versions: 0.92.0 > Environment: all > Reporter: honghua zhu > Fix For: 0.92.1 > > Attachments: HBASE-5491-2.patch, HBASE-5491.patch > > > Exec class has a field: "private Configuration conf = > HBaseConfiguration.create()" > Client side generates an Exec instance of the class, each initiated > Statistics request by ExecRPCInvoker > Is so HBaseConfiguration.create for each request needs to call > When the server side deserialize the Exec Called once > HBaseConfiguration.create in, > HBaseConfiguration.create is a time consuming operation. > "private Configuration conf = HBaseConfiguration.create()"; > This code is only useful for testing code > (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization), > other places with the Exec class, pass a Configuration come, > so no need to "conf" field a default value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira