[ 
https://issues.apache.org/jira/browse/HBASE-21047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583134#comment-16583134
 ] 

Hudson commented on HBASE-21047:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-1.3-IT #451 (See 
[https://builds.apache.org/job/HBase-1.3-IT/451/])
HBASE-21047 Object creation of StoreFileScanner thru constructor and (apurtell: 
rev efafa4108f75819c27e999a6b9e00fe9a37879ee)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java


> Object creation of StoreFileScanner thru constructor and close may leave 
> refCount to -1
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-21047
>                 URL: https://issues.apache.org/jira/browse/HBASE-21047
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Vishal Khandelwal
>            Assignee: Vishal Khandelwal
>            Priority: Major
>             Fix For: 3.0.0, 1.5.0, 1.3.3, 2.0.2, 2.2.0, 2.1.1, 1.4.7
>
>         Attachments: HBASE-21047.branch-1.v1.patch, 
> HBASE-21047.branch-1.v2.patch, HBASE-21047.v1.patch
>
>
> During object creation  "*StoreFileScanner*", it does not increase the 
> refCount whereas while close it decrements the reader refCount. This will 
> cause refCount to -1 and isReadReference method was returning true 
> (refCount.get() != 0 This is causing store file not to be deleted. This may 
> also cause issue in situation when some thread is holding a scanner but it 
> may actually be closed due to above bug. Impact of this would be really high. 
> Attatching patch for the fix which makes sure if reference is held either 
> thru getScanner method or constructor, ref is always updated. Patch also 
> contains a test which validates the issue. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to