[ 
https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586884#comment-16586884
 ] 

Reid Chan edited comment on HBASE-19008 at 8/21/18 3:27 AM:
------------------------------------------------------------

{{SingleColumnValueExcludeFilter}} extends {{SingleColumnValueFilter}} without 
additional properties, no need overriding {{equals}} and {{hashCode}}. 
 (I only skimmed one class and found a problem)

Far to go i'm afraid, please be patient and detailed, especially to this bored 
and tedious patch. :)


was (Author: reidchan):
{{SingleColumnValueExcludeFilter}} extends {{SingleColumnValueFilter}} without 
additional properties, no need overriding. 
(I only skimmed one class and found a problem)

Far to go i'm afraid, please be patient and detailed, especially to this bored 
and tedious patch. :) 

> Add missing equals or hashCode method(s) to stock Filter implementations
> ------------------------------------------------------------------------
>
>                 Key: HBASE-19008
>                 URL: https://issues.apache.org/jira/browse/HBASE-19008
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: liubangchen
>            Priority: Major
>              Labels: filter
>         Attachments: Filters.png, HBASE-19008-1.patch, HBASE-19008-10.patch, 
> HBASE-19008-11.patch, HBASE-19008-12.patch, HBASE-19008-13.patch, 
> HBASE-19008-14.patch, HBASE-19008-15.patch, HBASE-19008-2.patch, 
> HBASE-19008-3.patch, HBASE-19008-4.patch, HBASE-19008-5.patch, 
> HBASE-19008-6.patch, HBASE-19008-7.patch, HBASE-19008-8.patch, 
> HBASE-19008-9.patch, HBASE-19008.patch
>
>
> In HBASE-15410, [~mdrob] reminded me that Filter implementations may not 
> write {{equals}} or {{hashCode}} method(s).
> This issue is to add missing {{equals}} or {{hashCode}} method(s) to stock 
> Filter implementations such as KeyOnlyFilter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to