[
https://issues.apache.org/jira/browse/HBASE-21088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589169#comment-16589169
]
stack commented on HBASE-21088:
-------------------------------
That makes more sense to me at least (perhaps it just me). Patch is smaller too.
I think you should log a WARN here:
// continue with closing the remaining store files
... rather than have an empty catch block. Can say you are going to continue...
But if problem closing files, we probably want to know about it. Thanks.
> HStoreFile should be closed in HStore#hasReferences
> ---------------------------------------------------
>
> Key: HBASE-21088
> URL: https://issues.apache.org/jira/browse/HBASE-21088
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Attachments: 21088.v1.txt, 21088.v2.txt, 21088.v2.txt, 21088.v3.txt
>
>
> {code}
> reloadedStoreFiles = loadStoreFiles();
> return StoreUtils.hasReferences(reloadedStoreFiles);
> {code}
> The intention of obtaining the HStoreFile's is to check for references.
> The loaded HStoreFile's should be closed prior to return to prevent leak.
> I noticed the increase in open files when running test suite. After checking
> recently modified code, I came to this particular method.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
