[ https://issues.apache.org/jira/browse/HBASE-21117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593050#comment-16593050 ]
Xu Cang edited comment on HBASE-21117 at 8/26/18 11:04 PM: ----------------------------------------------------------- unit test failure is unrelated to this patch. It's tracking here:https://issues.apache.org/jira/browse/HBASE-21105 was (Author: xucang): Test "hadoop.hbase.util.TestHBaseFsck" started failing before this patch. e.g. https://issues.apache.org/jira/browse/HBASE-21067 > Backport HBASE-18350 (fix RSGroups) to branch-1 (Only port the part fixing > table locking issue.) > -------------------------------------------------------------------------------------------------- > > Key: HBASE-21117 > URL: https://issues.apache.org/jira/browse/HBASE-21117 > Project: HBase > Issue Type: Bug > Components: backport, rsgroup, shell > Affects Versions: 1.3.2 > Reporter: Xu Cang > Assignee: Xu Cang > Priority: Major > Labels: backport > Attachments: HBASE-21117-branch-1.001.patch, > HBASE-21117-branch-1.002.patch > > > When working on HBASE-20666, I found out HBASE-18350 did not get ported to > branch-1, which causes procedure to hang when #moveTables called sometimes. > After looking into the 18350 patch, seems it's important since it fixes 4 > issues. This Jira is an attempt to backport it to branch-1. > > > Edited: Aug26. > After reviewed the HBASE-18350 patch. I decided to only port part 2 of the > patch. > Because part1 and part3 is AMv2 related. I won't touch is since Amv2 is only > for branch-2 > > {quote} > Subject: [PATCH] HBASE-18350 RSGroups are broken under AMv2 > - Table moving to RSG was buggy, because it left the table unassigned. > Now it is fixed we immediately assign to an appropriate RS > (MoveRegionProcedure). > *- Table was locked while moving, but unassign operation hung, because* > *locked table queues are not scheduled while locked. Fixed. ---- port > this one.* > - ProcedureSyncWait was buggy, because it searched the procId in > executor, but executor does not store the return values of internal > operations (they are stored, but immediately removed by the cleaner). > - list_rsgroups in the shell show also the assigned tables and servers. > {quote} -- This message was sent by Atlassian JIRA (v7.6.3#76005)