[ 
https://issues.apache.org/jira/browse/HBASE-21001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605319#comment-16605319
 ] 

Wei-Chiu Chuang commented on HBASE-21001:
-----------------------------------------

[~andrewcheng] thanks for the patch. Looks good to me.
Any chance to add a test? I mean, this regression went unnoticed because there 
is no existing test that covers it.
Not sure if it is feasible given that ReplicationObserver and HRegion are in 
different modules. A test can be added separately in a new jira or in this 
patch. Either way works for me.

+1 (non-binding)
Thanks

> ReplicationObserver fails to load in HBase 2.0.0
> ------------------------------------------------
>
>                 Key: HBASE-21001
>                 URL: https://issues.apache.org/jira/browse/HBASE-21001
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha-4, 2.0.0
>            Reporter: Wei-Chiu Chuang
>            Assignee: Guangxu Cheng
>            Priority: Major
>              Labels: replication
>         Attachments: HBASE-21001.master.001.patch, 
> HBASE-21001.master.001.patch
>
>
> ReplicationObserver was added in HBASE-17290 to prevent "Potential loss of 
> data for replication of bulk loaded hfiles".
> I tried to enable bulk loading replication feature 
> (hbase.replication.bulkload.enabled=true and configure 
> hbase.replication.cluster.id) on a HBase 2.0.0 cluster, but the RegionServer 
> started with the following error:
> {quote}
> 2018-08-02 18:20:36,365 INFO 
> org.apache.hadoop.hbase.regionserver.RegionServerCoprocessorHost: System 
> coprocessor loading is enabled
> 2018-08-02 18:20:36,365 INFO 
> org.apache.hadoop.hbase.regionserver.RegionServerCoprocessorHost: Table 
> coprocessor loading is enabled
> 2018-08-02 18:20:36,365 ERROR 
> org.apache.hadoop.hbase.regionserver.RegionServerCoprocessorHost: 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationObserver is not 
> of type
> RegionServerCoprocessor. Check the configuration of 
> hbase.coprocessor.regionserver.classes
> 2018-08-02 18:20:36,366 ERROR 
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost: Cannot load coprocessor 
> ReplicationObserver
> {quote}
> It looks like this was broken by HBASE-17732 to me, but I could be wrong. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to