[ https://issues.apache.org/jira/browse/HBASE-21138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606610#comment-16606610 ]
Mingliang Liu commented on HBASE-21138: --------------------------------------- Thanks for helpful review comments, and commit. > Close HRegion instance at the end of every test in TestHRegion > -------------------------------------------------------------- > > Key: HBASE-21138 > URL: https://issues.apache.org/jira/browse/HBASE-21138 > Project: HBase > Issue Type: Test > Reporter: Ted Yu > Assignee: Mingliang Liu > Priority: Major > Fix For: 3.0.0, 1.5.0, 2.2.0 > > Attachments: HBASE-21138.000.patch, HBASE-21138.001.patch, > HBASE-21138.002.patch, HBASE-21138.003.patch, HBASE-21138.004.patch, > HBASE-21138.branch-1.004.patch, HBASE-21138.branch-1.004.patch, > HBASE-21138.branch-2.004.patch > > > TestHRegion has over 100 tests. > The following is from one subtest: > {code} > public void testCompactionAffectedByScanners() throws Exception { > byte[] family = Bytes.toBytes("family"); > this.region = initHRegion(tableName, method, CONF, family); > {code} > this.region is not closed at the end of the subtest. > testToShowNPEOnRegionScannerReseek is another example. > Every subtest should use the following construct toward the end: > {code} > } finally { > HBaseTestingUtility.closeRegionAndWAL(this.region); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)