[
https://issues.apache.org/jira/browse/HBASE-21206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620810#comment-16620810
]
Zheng Hu commented on HBASE-21206:
----------------------------------
bq. It seems that you replied on the review board and said 'It's reasonable.
Thanks', but in patch v3 you haven't changed the code?
No, I've fixed the comment. you can see:
https://reviews.apache.org/r/68745/diff/3-4/
Upload HBASE-21206.branch-1.v1.patch for branch-1.4 & branch-1. Checked the
code, branch-1.2 & branch-1.3 didn't has this bug, because it did not
consider the batch limit case as partial result [1] ... at the client side,
if rpc return two results, the first with 2 cells, the second with 3 cells,
when scan with batch=3, the client will just read the first result with 2
cells, and the next result with 3 cells... it does not collect them into 3 +
2... the javadoc also indicate this [2].. so we just keep the semantic.
BTW HBASE-21206.v3.patch can be applied to branch-2.0 & branch2.1 & master ..
1.
https://github.com/apache/hbase/blob/branch-1.2/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L2617
2.
https://github.com/apache/hbase/blob/branch-1.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L470
> Scan with batch size may return incomplete cells
> ------------------------------------------------
>
> Key: HBASE-21206
> URL: https://issues.apache.org/jira/browse/HBASE-21206
> Project: HBase
> Issue Type: Bug
> Components: scan
> Reporter: Zheng Hu
> Assignee: Zheng Hu
> Priority: Critical
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.8, 2.1.1, 2.0.3
>
> Attachments: HBASE-21206.v1.patch, HBASE-21206.v1.patch,
> HBASE-21206.v2.patch, HBASE-21206.v3.patch, ut.patch
>
>
> See the attached UT. the table has 5 columns and each column has at least
> one cell in it, but when we scan the table with batchSize=3, we only got 3
> cells returned , the other 2 cells got lost ...
> It's a critial bug and should be fixed..
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
