[ https://issues.apache.org/jira/browse/HBASE-21213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624480#comment-16624480 ]
Hadoop QA commented on HBASE-21213: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 3 new or modified test files. {color} | || || || || {color:brown} branch-2.1 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 25s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 18s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m 6s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 33s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 35s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 45s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 40s{color} | {color:green} branch-2.1 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 16m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 16m 57s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} hbase-procedure: The patch generated 2 new + 20 unchanged - 0 fixed = 22 total (was 20) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 15s{color} | {color:red} hbase-server: The patch generated 12 new + 266 unchanged - 0 fixed = 278 total (was 266) {color} | | {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 3s{color} | {color:red} The patch generated 2 new + 3 unchanged - 1 fixed = 5 total (was 4) {color} | | {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} 0m 1s{color} | {color:green} There were no new ruby-lint issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 28s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 8m 33s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 30s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 56s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 47s{color} | {color:green} hbase-procedure in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green}111m 52s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 40s{color} | {color:red} hbase-rsgroup in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 6m 57s{color} | {color:red} hbase-shell in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 51s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}211m 47s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.master.balancer.TestRSGroupBasedLoadBalancer | | | hadoop.hbase.client.TestShell | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:42ca976 | | JIRA Issue | HBASE-21213 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12940872/HBASE-21213.branch-2.1.004.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc rubocop ruby_lint | | uname | Linux 4fc4510aae34 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-2.1 / 101205345b | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/14476/artifact/patchprocess/diff-checkstyle-hbase-procedure.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/14476/artifact/patchprocess/diff-checkstyle-hbase-server.txt | | rubocop | v0.58.2 | | rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/14476/artifact/patchprocess/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/14476/artifact/patchprocess/patch-unit-hbase-rsgroup.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/14476/artifact/patchprocess/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/14476/testReport/ | | Max. process+thread count | 4882 (vs. ulimit of 10000) | | modules | C: hbase-protocol-shaded hbase-client hbase-procedure hbase-server hbase-rsgroup hbase-shell U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/14476/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > [hbck2] bypass leaves behind state in RegionStates when assign/unassign > ----------------------------------------------------------------------- > > Key: HBASE-21213 > URL: https://issues.apache.org/jira/browse/HBASE-21213 > Project: HBase > Issue Type: Bug > Components: amv2, hbck2 > Reporter: stack > Assignee: stack > Priority: Major > Fix For: 2.1.1 > > Attachments: HBASE-21213.branch-2.1.001.patch, > HBASE-21213.branch-2.1.002.patch, HBASE-21213.branch-2.1.003.patch, > HBASE-21213.branch-2.1.004.patch > > > This is a follow-on from HBASE-21083 which added the 'bypass' functionality. > On bypass, there is more state to be cleared if we are allow new Procedures > to be scheduled. > For example, here is a bypass: > {code} > 2018-09-20 05:45:43,722 INFO org.apache.hadoop.hbase.procedure2.Procedure: > pid=100449, state=RUNNABLE:REGION_TRANSITION_DISPATCH, locked=true, > bypass=LOG-REDACTED UnassignProcedure table=hbase:namespace, > region=37cc206fe9c4bc1c0a46a34c5f523d16, > server=ve1233.halxg.cloudera.com,22101,1537397961664 bypassed, returning null > to finish it > 2018-09-20 05:45:44,022 INFO > org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=100449, > state=SUCCESS, bypass=LOG-REDACTED UnassignProcedure table=hbase:namespace, > region=37cc206fe9c4bc1c0a46a34c5f523d16, > server=ve1233.halxg.cloudera.com,22101,1537397961664 in 2mins, 7.618sec > {code} > ... but then when I try to assign the bypassed region later, I get this: > {code} > 2018-09-20 05:46:31,435 WARN > org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure: There is > already another procedure running on this region this=pid=100450, > state=RUNNABLE:REGION_TRANSITION_QUEUE, locked=true; AssignProcedure > table=hbase:namespace, region=37cc206fe9c4bc1c0a46a34c5f523d16 > owner=pid=100449, state=SUCCESS, bypass=LOG-REDACTED UnassignProcedure > table=hbase:namespace, region=37cc206fe9c4bc1c0a46a34c5f523d16, > server=ve1233.halxg.cloudera.com,22101,1537397961664 pid=100450, > state=RUNNABLE:REGION_TRANSITION_QUEUE, locked=true; AssignProcedure > table=hbase:namespace, region=37cc206fe9c4bc1c0a46a34c5f523d16; rit=OPENING, > location=ve1233.halxg.cloudera.com,22101,1537397961664 > 2018-09-20 05:46:31,510 INFO > org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Rolled back pid=100450, > state=ROLLEDBACK, > exception=org.apache.hadoop.hbase.procedure2.ProcedureAbortedException via > AssignProcedure:org.apache.hadoop.hbase.procedure2.ProcedureAbortedException: > There is already another procedure running on this region this=pid=100450, > state=RUNNABLE:REGION_TRANSITION_QUEUE, locked=true; AssignProcedure > table=hbase:namespace, region=37cc206fe9c4bc1c0a46a34c5f523d16 > owner=pid=100449, state=SUCCESS, bypass=LOG-REDACTED UnassignProcedure > table=hbase:namespace, region=37cc206fe9c4bc1c0a46a34c5f523d16, > server=ve1233.halxg.cloudera.com,22101,1537397961664; AssignProcedure > table=hbase:namespace, region=37cc206fe9c4bc1c0a46a34c5f523d16 > exec-time=473msec > {code} > ... which is a long-winded way of saying the Unassign Procedure still exists > still in RegionStateNodes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)