[ 
https://issues.apache.org/jira/browse/HBASE-5512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221926#comment-13221926
 ] 

Hadoop QA commented on HBASE-5512:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12516970/5512-v2.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated -129 warning 
messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 154 new Findbugs (version 
1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1091//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1091//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1091//console

This message is automatically generated.
                
> Add support for INCLUDE_AND_SEEK_USING_HINT
> -------------------------------------------
>
>                 Key: HBASE-5512
>                 URL: https://issues.apache.org/jira/browse/HBASE-5512
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Zhihong Yu
>            Assignee: Lars Hofhansl
>         Attachments: 5512-v2.txt, 5512.txt
>
>
> This came up from HBASE-2038
> From Anoop:
> - What we wanted from the filter is include a row and then seek to the next 
> row which we are interested in. I cant see such a facility with our Filter 
> right now. Correct me if I am wrong. So suppose we already seeked to one row 
> and this need to be included in the result, then the Filter should return 
> INCLUDE. Then when the next next() call happens, then only we can return a 
> SEEK_USING_HINT. So one extra row reading is needed. This might create even 
> one unwanted HFileBlock fetch (who knows).
> Can we add reseek() at higher level?
> From Lars:
> Yep, for that we'd need to add INCLUDE_AND_SEEK_USING_HINT (similar to the 
> INCLUDE_AND_SEEK_NEXT_ROW that we already have). Shouldn't be hard to add, 
> I'm happy to do that, if that's the route we want to go with this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to