[ https://issues.apache.org/jira/browse/HBASE-20734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628222#comment-16628222 ]
Reid Chan edited comment on HBASE-20734 at 9/26/18 3:47 AM: ------------------------------------------------------------ Conflicts in branch-2, {code} <<<<<<< HEAD 51 * ClassSize.REFERENCE + 3 * Bytes.SIZEOF_INT + (14 * Bytes.SIZEOF_LONG) + ======= 53 * ClassSize.REFERENCE + 3 * Bytes.SIZEOF_INT + (15 * Bytes.SIZEOF_LONG) + >>>>>>> 0e173d38b0... HBASE-20734 Colocate recovered edits directory with >>>>>>> hbase.wal.dir {code} I kept the {{(14 * Bytes.SIZEOF_LONG)}} because this patch doesn't add long number in {{HRegion.java}}. was (Author: reidchan): Conflicts in branch-2, {code} <<<<<<< HEAD 51 * ClassSize.REFERENCE + 3 * Bytes.SIZEOF_INT + (14 * Bytes.SIZEOF_LONG) + ======= 53 * ClassSize.REFERENCE + 3 * Bytes.SIZEOF_INT + (15 * Bytes.SIZEOF_LONG) + >>>>>>> 0e173d38b0... HBASE-20734 Colocate recovered edits directory with >>>>>>> hbase.wal.dir {code} I kept the {{(14 * Bytes.SIZEOF_LONG)}} because this patch doesn't include any new added long. > Colocate recovered edits directory with hbase.wal.dir > ----------------------------------------------------- > > Key: HBASE-20734 > URL: https://issues.apache.org/jira/browse/HBASE-20734 > Project: HBase > Issue Type: Improvement > Components: MTTR, Recovery, wal > Reporter: Ted Yu > Assignee: Zach York > Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20734.branch-1.001.patch, > HBASE-20734.branch-1.002.patch, HBASE-20734.branch-1.003.patch, > HBASE-20734.branch-1.004.patch, HBASE-20734.branch-1.005.patch, > HBASE-20734.master.001.patch, HBASE-20734.master.002.patch, > HBASE-20734.master.003.patch, HBASE-20734.master.004.patch, > HBASE-20734.master.005.patch, HBASE-20734.master.006.patch, > HBASE-20734.master.007.patch, HBASE-20734.master.008.patch, > HBASE-20734.master.009.patch, HBASE-20734.master.010.patch, > HBASE-20734.master.011.patch, HBASE-20734.master.012.patch > > > During investigation of HBASE-20723, I realized that we wouldn't get the best > performance when hbase.wal.dir is configured to be on different (fast) media > than hbase rootdir w.r.t. recovered edits since recovered edits directory is > currently under rootdir. > Such setup may not result in fast recovery when there is region server > failover. > This issue is to find proper (hopefully backward compatible) way in > colocating recovered edits directory with hbase.wal.dir . -- This message was sent by Atlassian JIRA (v7.6.3#76005)