[ 
https://issues.apache.org/jira/browse/HBASE-20766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629453#comment-16629453
 ] 

Sean Busbey commented on HBASE-20766:
-------------------------------------

{code}

| Vote |       Subsystem |  Runtime   | Comment
============================================================================
|      |                 |            | Prechecks 
|   0  |       findbugs  |   0m 00s   | Findbugs executables are not available. 
|  +1  |      hbaseanti  |   0m 00s   | Patch does not have any anti-patterns. 
|  +1  |        @author  |   0m 00s   | The patch does not contain any @author 
|      |                 |            | tags.
|  -1  |     test4tests  |   0m 00s   | The patch doesn't appear to include any 
|      |                 |            | new or modified tests. Please justify
|      |                 |            | why no new tests are needed for this
|      |                 |            | patch. Also please list what manual
|      |                 |            | steps were performed to verify this
|      |                 |            | patch.
|      |                 |            | master Compile Tests 
|  +1  |     mvninstall  |   6m 17s   | master passed 
|  +1  |        compile  |   0m 46s   | master passed 
|  +1  |     checkstyle  |   0m 24s   | master passed 
|  +1  |     shadedjars  |   5m 00s   | branch has no errors when building our 
|      |                 |            | shaded downstream artifacts.
|  +1  |        javadoc  |   0m 28s   | master passed 
|      |                 |            | Patch Compile Tests 
|  +1  |     mvninstall  |   5m 35s   | the patch passed 
|  +1  |        compile  |   0m 46s   | the patch passed 
|  -1  |          javac  |   0m 46s   | hbase-mapreduce generated 158 new + 0 
|      |                 |            | unchanged - 158 fixed = 158 total (was
|      |                 |            | 158)
|  +1  |     checkstyle  |   0m 33s   | the patch passed 
|  +1  |     whitespace  |   0m 00s   | The patch has no whitespace issues. 
|  +1  |     shadedjars  |   5m 11s   | patch has no errors when building our 
|      |                 |            | shaded downstream artifacts.
|  +1  |    hadoopcheck  |  29m 22s   | Patch does not cause any errors with 
|      |                 |            | Hadoop 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0.
|  +1  |        javadoc  |   0m 27s   | the patch passed 
|      |                 |            | Other Tests 
|  +1  |     asflicense  |   0m 14s   | The patch does not generate ASF License 
|      |                 |            | warnings.
|      |                 |  55m 23s   | 
{code}

test4tests we don't treat as -1 and this ought not have a test because it's an 
error message.

the javac warnings are a false positive where the maven timestamps weren't 
properly filtered.

> Verify Replication Tool Has Typo "remove cluster"
> -------------------------------------------------
>
>                 Key: HBASE-20766
>                 URL: https://issues.apache.org/jira/browse/HBASE-20766
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Clay B.
>            Assignee: Ferran Fernandez Garrido
>            Priority: Trivial
>              Labels: beginner
>         Attachments: HBASE-20766.master.001.patch
>
>
> The verify replication tool has a trivial typo "remove cluster" instead of 
> "remote cluster": 
> https://github.com/apache/hbase/blob/a6eeb26cc0b4d0af3fff50b5b931b6847df1f9d2/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java#L355



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to