[
https://issues.apache.org/jira/browse/HBASE-21250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633649#comment-16633649
]
Duo Zhang commented on HBASE-21250:
-----------------------------------
There are already plenty of comments for the WALProcedureMap and [~stack] has
already played with it in the past so I think it is fine for now. Let's finish
this issue and I will try to fix the fencing, i.e, recover lease problem, and
also HBASE-21254.
Ping [~allan163] [~stack] for reviewing.
Thanks.
> Refactor WALProcedureStore and add more comments for better understanding the
> implementation
> --------------------------------------------------------------------------------------------
>
> Key: HBASE-21250
> URL: https://issues.apache.org/jira/browse/HBASE-21250
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: HBASE-21250-v1.patch, HBASE-21250-v2.patch,
> HBASE-21250.patch
>
>
> The implementation is complicated and lack of comments to say how it works.
> {code}
> /**
> * WAL implementation of the ProcedureStore.
> * @see ProcedureWALPrettyPrinter for printing content of a single WAL.
> * @see #main(String[]) to parse a directory of MasterWALProcs.
> */
> {code}
> I think at least we can move sub classes to separated files to make the class
> smaller, and add more comments to describe what is going on here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
