[ https://issues.apache.org/jira/browse/HBASE-19275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635254#comment-16635254 ]
Hudson commented on HBASE-19275: -------------------------------- Results for branch branch-2.0 [build #893 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/893/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/893//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/893//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/893//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > TestSnapshotFileCache never worked properly > ------------------------------------------- > > Key: HBASE-19275 > URL: https://issues.apache.org/jira/browse/HBASE-19275 > Project: HBase > Issue Type: Sub-task > Affects Versions: 3.0.0, 1.4.0, 1.5.0, 2.0.0 > Reporter: Andrew Purtell > Assignee: Xu Cang > Priority: Major > Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.8, 2.1.1, 2.0.3 > > Attachments: HBASE-19275-branch-1.patch, > HBASE-19275-master.001.patch, HBASE-19275-master.001.patch > > > Error-prone noticed we were asking Iterables.contains() questions with the > wrong type in TestSnapshotFileCache. I've attached a fixed version of the > test. The results suggest the cache is not evicting entries properly. > {noformat} > java.lang.AssertionError: Cache found > 'hdfs://localhost:52867/user/apurtell/test-data/8ce04c85-ce4b-4844-b454-5303482ade95/data/default/snapshot1/9e49edd0ab41657fb0c6ebb4d9dfad15/cf/f132e5b06f66443f8003363ed1535aac', > but it shouldn't have. > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertFalse(Assert.java:64) > at > org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.createAndTestSnapshot(TestSnapshotFileCache.java:260) > at > org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.createAndTestSnapshotV1(TestSnapshotFileCache.java:206) > at > org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.testReloadModifiedDirectory(TestSnapshotFileCache.java:102) > {noformat} > {noformat} > java.lang.AssertionError: Cache found > 'hdfs://localhost:52867/user/apurtell/test-data/8ce04c85-ce4b-4844-b454-5303482ade95/data/default/snapshot1a/2e81adb9212c98cff970eafa006fc40b/cf/a2ec478d850e4e348359699c53b732c4', > but it shouldn't have. > at org.junit.Assert.fail(Assert.java:88) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertFalse(Assert.java:64) > at > org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.createAndTestSnapshot(TestSnapshotFileCache.java:260) > at > org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.createAndTestSnapshotV1(TestSnapshotFileCache.java:206) > at > org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.testLoadAndDelete(TestSnapshotFileCache.java:88) > {noformat} > These changes are part of HBASE-19239 > I've disabled the offending test cases with @Ignore in that patch, but they > should be reenabled and fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)