[ https://issues.apache.org/jira/browse/HBASE-21242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639272#comment-16639272 ]
Hadoop QA commented on HBASE-21242: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange} 0m 0s{color} | {color:orange} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} branch-2 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 23s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 22s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 51s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 1s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 41s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 28s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} branch-2 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 51s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 12s{color} | {color:red} hbase-server: The patch generated 1 new + 7 unchanged - 0 fixed = 8 total (was 7) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 43s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 8m 42s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 59s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 50s{color} | {color:green} hbase-procedure in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}209m 50s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 2s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}262m 1s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.master.assignment.TestAssignmentManager | | | hadoop.hbase.master.TestRestartCluster | | | hadoop.hbase.regionserver.TestMutateRowsRecovery | | | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation | | | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleWAL | | | hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL | | | hadoop.hbase.regionserver.TestSplitTransactionOnCluster | | | hadoop.hbase.regionserver.TestPerColumnFamilyFlush | | | hadoop.hbase.regionserver.wal.TestSecureWALReplay | | | hadoop.hbase.TestFullLogReconstruction | | | hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash | | | hadoop.hbase.coprocessor.TestRegionObserverInterface | | | hadoop.hbase.regionserver.TestHRegionOnCluster | | | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay | | | hadoop.hbase.replication.TestReplicationKillMasterRSWithSeparateOldWALs | | | hadoop.hbase.master.TestServerCrashProcedureStuck | | | hadoop.hbase.master.TestRollingRestart | | | hadoop.hbase.client.TestAsyncTableBatch | | | hadoop.hbase.TestRegionRebalancing | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.client.TestHTableMultiplexerFlushCache | | | hadoop.hbase.regionserver.TestRegionServerCrashDisableWAL | | | hadoop.hbase.master.procedure.TestServerCrashProcedure | | | hadoop.hbase.master.procedure.TestServerCrashProcedureWithReplicas | | | hadoop.hbase.client.TestMetaWithReplicas | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplay | | | hadoop.hbase.TestZooKeeper | | | hadoop.hbase.replication.TestReplicationDroppedTables | | | hadoop.hbase.TestMultiVersions | | | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed | | | hadoop.hbase.master.assignment.TestAMAssignWithRandExec | | | hadoop.hbase.regionserver.TestCompactionInDeadRegionServer | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService | | | hadoop.hbase.regionserver.wal.TestWALReplay | | | hadoop.hbase.master.balancer.TestFavoredNodeTableImport | | | hadoop.hbase.regionserver.TestShutdownWhileWALBroken | | | hadoop.hbase.regionserver.TestSplitWalDataLoss | | | hadoop.hbase.regionserver.TestRegionReplicaFailover | | | hadoop.hbase.regionserver.wal.TestWALReplayCompressed | | | hadoop.hbase.replication.TestSerialReplicationFailover | | | hadoop.hbase.client.TestConnectionImplementation | | | hadoop.hbase.client.TestMultiParallel | | | hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService | | | hadoop.hbase.master.TestDLSAsyncFSWAL | | | hadoop.hbase.regionserver.TestEncryptionKeyRotation | | | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon | | | hadoop.hbase.TestIOFencing | | | hadoop.hbase.client.TestScannerTimeout | | | hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:42ca976 | | JIRA Issue | HBASE-21242 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12942491/HBASE-21242.branch-2.001.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8ee829e0e9cc 4.4.0-134-generic #160~14.04.1-Ubuntu SMP Fri Aug 17 11:07:07 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-2 / 24d19e87e0 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/14575/artifact/patchprocess/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/14575/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/14575/testReport/ | | Max. process+thread count | 4656 (vs. ulimit of 10000) | | modules | C: hbase-client hbase-procedure hbase-server U: . | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/14575/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > [amv2] Miscellaneous minor log and assign procedure create improvements > ----------------------------------------------------------------------- > > Key: HBASE-21242 > URL: https://issues.apache.org/jira/browse/HBASE-21242 > Project: HBase > Issue Type: Bug > Components: amv2, Operability > Reporter: stack > Assignee: stack > Priority: Minor > Fix For: 3.0.0, 2.2.0, 2.1.1, 2.0.3 > > Attachments: HBASE-21242.branch-2.0.001.patch, > HBASE-21242.branch-2.001.patch, HBASE-21242.branch-2.1.001.patch, > HBASE-21242.branch-2.1.001.patch, HBASE-21242.branch-2.1.001.patch, > HBASE-21242.branch-2.1.002.patch > > > Some minor fixups: > {code} > For RIT Duration, do better than print ms/seconds. Remove redundant UI > column dedicated to duration when we log it in the status field too. > Make bypass log at INFO level -- when DEBUG we can miss important > fixup detail like why we failed. > Make it so on complete of subprocedure, we note count of outstanding > siblings so we have a clue how much further the parent has to go before > it is done (Helpful when hundreds of servers doing SCP). > Have the SCP run the AP preflight check before creating an AP; saves > creation of hundreds of thousands of APs during fixup of this big cluster > of mine. > Don't log tablename three times when reporting remote call failed. > If lock is held already, note who has it. Also log after we get lock > or if we have to wait rather than log on entrance though we may > later have to wait (or we may have just picked up the lock). > {code} > Posting patch in a sec but let me try it on cluster too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)