[ 
https://issues.apache.org/jira/browse/HBASE-5515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222778#comment-13222778
 ] 

Phabricator commented on HBASE-5515:
------------------------------------

sc has commented on the revision "HBASE-5515 [jira] Add a processRow API that 
supports atomic multiple reads and writes on a row".

  Ted: Wow, that was super quick! Thanks!

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/coprocessor/RowProcessor.java:72 This 
is actually for the application to override to create their own processor. I 
should document this more clearly. I will make the change.

  I am passing the walEdit here because internally we also submit some meta 
data to walEdit (kind of like you can send SQL comments to binlog). Basically 
passing walEdit here allow us to do more things.
  src/main/java/org/apache/hadoop/hbase/coprocessor/RowProcessor.java:43 good 
point.
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:4379 yes. I 
will make the change.

REVISION DETAIL
  https://reviews.facebook.net/D2067

                
> Add a processRow API that supports atomic multiple reads and writes on a row
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-5515
>                 URL: https://issues.apache.org/jira/browse/HBASE-5515
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>         Attachments: HBASE-5515.D2067.1.patch, HBASE-5515.D2067.10.patch, 
> HBASE-5515.D2067.2.patch, HBASE-5515.D2067.3.patch, HBASE-5515.D2067.4.patch, 
> HBASE-5515.D2067.5.patch, HBASE-5515.D2067.6.patch, HBASE-5515.D2067.7.patch, 
> HBASE-5515.D2067.8.patch, HBASE-5515.D2067.9.patch
>
>
> We have modified HRegion.java internally to do some atomic row processing. It 
> will be nice to have a plugable API for this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to