[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645687#comment-16645687
]
Josh Elser commented on HBASE-21246:
------------------------------------
{code:java}
+ * For the FS based path, it will be just a filename of whole path
+ * For stream based, it will be name of the stream{code}
I dont' see these adding value. Doesn't belong in the interface (can be a
comment on implementation if necessary).
{quote}This would be used in the (Ankit's) upcoming patch for replication.
{quote}
Introduce it then, please.
{quote}The start time of a WAL is known at the creation of the WAL. This
attribute would not change even after edits are appended to the WAL.
Therefore I think it belongs to the identity.
{quote}
My take is that for most cases, we would be querying the backend system to
obtain this information (as opposed to having it encoded in the name like we do
for HDFS). If it were always something we encode in the names, I could see
putting it into the WALIdentity, but I think HDFS is the exception, not the
rule.
> Introduce WALIdentity interface
> -------------------------------
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Attachments: 21246.003.patch, 21246.HBASE-20952.001.patch,
> 21246.HBASE-20952.002.patch, 21246.HBASE-20952.004.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent
> filename in distributed filesystem environment or, the name of the stream
> when the WAL is backed by log stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
