[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646663#comment-16646663
]
Sean Busbey commented on HBASE-21247:
-------------------------------------
Ted, please re-read my comment and the javadoc I copied all the way to the end.
There's an enum that is meant to show the "this is the safe path" surface for
the API. The config also allows you to provide any fully qualified java class
name. The feature has been around as long as we've had the
{{hbase.wal.provider}} config.
This code here in WALFactory.java (that's even still present after your patch):
{code}
169 } catch (IllegalArgumentException exception) {
170 // Fall back to them specifying a class name
171 // Note that the passed default class shouldn't actually be used,
since the above only fails
172 // when there is a config value present.
173 return conf.getClass(key, AsyncFSWALProvider.class, WALProvider.class);
174 }
{code}
To be very, very clear: I vote -1 and veto this change on the technical basis
that it adds no new functionality and instead just makes our configuration
confusing. Please revert it or I will take care of doing so as my schedule
allows.
> Allow WAL Provider to be specified by configuration without explicit enum in
> Providers
> --------------------------------------------------------------------------------------
>
> Key: HBASE-21247
> URL: https://issues.apache.org/jira/browse/HBASE-21247
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: 21247.v1.txt, 21247.v2.txt, 21247.v3.txt, 21247.v4.txt
>
>
> Currently all the WAL Providers acceptable to hbase are specified in
> Providers enum of WALFactory.
> This restricts the ability for additional WAL Providers to be supplied - by
> class name.
> This issue introduces additional config which allows the specification of new
> WAL Provider through class name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
