[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647917#comment-16647917
]
Sean Busbey commented on HBASE-21247:
-------------------------------------
in v6 you still have two different places that try to load by classname. You
also load the class the wrong way (you should be using conf.getClass). Why does
the one after the enum get the wrong name?
{quote}
The test failures for patch v6 were not related to the patch.
{code}
[INFO] Running org.apache.hadoop.hbase.wal.TestWALFactory
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.959
s - in org.apache.hadoop.hbase.wal.TestWALFactory
{code}
{quote}
Do you say this because you ran the tests that failed locally? Because you
looked at them and reasoned through the failure? Or just because they aren't
the specific test you modified?
> Custom WAL Provider cannot be specified by configuration whose value is
> outside the enums in Providers
> ------------------------------------------------------------------------------------------------------
>
> Key: HBASE-21247
> URL: https://issues.apache.org/jira/browse/HBASE-21247
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: 21247.v1.txt, 21247.v2.txt, 21247.v3.txt, 21247.v4.tst,
> 21247.v4.txt, 21247.v5.txt, 21247.v6.txt
>
>
> Currently all the WAL Providers acceptable to hbase are specified in
> Providers enum of WALFactory.
> This restricts the ability for additional WAL Providers to be supplied - by
> class name.
> This issue fixes the bug by allowing the specification of new WAL Provider
> class name using the config "hbase.wal.provider".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
