[
https://issues.apache.org/jira/browse/HBASE-21263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653524#comment-16653524
]
Wellington Chevreuil edited comment on HBASE-21263 at 10/18/18 8:22 AM:
------------------------------------------------------------------------
Hi [~apurtell],
Seems branch-1 patch broke branch-1.4 build (am getting same error on my local):
[https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/511//artifact/output-jdk8-hadoop2/patch-compile-root.txt]
I guess branch-1.4 is missing HBASE-19858, tried cherry pick it on my local
branch-1.4, then it worked after doing small fix on TestHRegionFileSystem.java
due changes on PerformanceEvaluation.FAMILY_NAME_BASE type made by HBASE-19858.
I can submit a rebased patch with this HBASE-19858 and required fix, to be
easily applied on branch-1.4. Let me know what you think.
was (Author: wchevreuil):
Hi [~apurtell],
Seems branch-1 patch broke branch-1.4 build (am getting same error on my local):
[https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/511//artifact/output-jdk8-hadoop2/patch-compile-root.txt]
I guess branch-1.4 is missing HBASE-19858, tried cherry pick it on my local
branch-1.4, then it worked after doing small fix on TestHRegionFileSystem.java
due changes on PerformanceEvaluation.FAMILY_NAME_BASE type made by HBASE-19858.
I can submit a rebased patch with this HBASE-19858 and required fix, to be
easily applied on branch-1.5. Let me know what you think.
> Mention compression algorithm along with other storefile details
> ----------------------------------------------------------------
>
> Key: HBASE-21263
> URL: https://issues.apache.org/jira/browse/HBASE-21263
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Subrat Mishra
> Priority: Minor
> Labels: beginner, beginners
> Fix For: 3.0.0, 1.5.0, 1.3.3, 1.2.8, 2.2.0, 2.1.1, 2.0.3, 1.4.9
>
> Attachments: HBASE-21263-branch-1.patch,
> HBASE-21263-branch-2.0.patch, HBASE-21263.master.001.patch,
> HBASE-21263.master.002.patch, HBASE-21263.master.003.patch, HBASE-21263.patch
>
>
> Where we log storefile details we should also log the compression algorithm
> used to compress blocks on disk, if any.
> For example, here's a log line out of compaction:
> 2018-10-02 21:59:47,594 DEBUG
> [regionserver/host/1.1.1.1:8120-longCompactions-1538517461152]
> compactions.Compactor: Compacting
> hdfs://namenode:8020/hbase/data/default/TestTable/86037c19117a46b5b8148439ea55753b/i/3d04a7c28d6343ceb773737dbb192533,
> keycount=3335873, bloomtype=ROW, size=107.5 M, encoding=ROW_INDEX_V1,
> seqNum=154199, earliestPutTs=1538516084915
> Aside from bloom type, block encoding, and filename, it would be good to know
> compression type in this type of DEBUG or INFO level logging. A minor
> omission of information that could be helpful during debugging.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
