[
https://issues.apache.org/jira/browse/HBASE-21352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657864#comment-16657864
]
Duo Zhang commented on HBASE-21352:
-----------------------------------
I think the current rollback implementation still has some problems. When a sub
procedure is failed, we will mark the RootProcedureState as failed immediately,
when calling addRollbackStep. And for later sub procedures, when calling
RootProcedureState.acquire, it will get a false and start to rolling back, no
matter whether the sub procedure support rolling back or not...
I think the correct behavior is to let the sub procedures to finish, and then
we start to rollback. At least for TRSP, it is not possible to rollback in the
middle and it will lead to a broken state.
Let me think how to fix this...
> Polish the rollback implementation in ProcedureExecutor
> -------------------------------------------------------
>
> Key: HBASE-21352
> URL: https://issues.apache.org/jira/browse/HBASE-21352
> Project: HBase
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Priority: Major
>
> Need to confirm that the way we make sure that there is one PE worker which
> rollback the whole procedure stack is correct. Now the comment is not enough.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
