[ https://issues.apache.org/jira/browse/HBASE-21354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658071#comment-16658071 ]
Hadoop QA commented on HBASE-21354: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | || || || || {color:brown} branch-2.0 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 34s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 12s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 34s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} branch-2.0 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m 43s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 14s{color} | {color:red} hbase-procedure: The patch generated 2 new + 10 unchanged - 0 fixed = 12 total (was 10) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 2m 39s{color} | {color:red} patch has 26 errors when building our shaded downstream artifacts. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 41s{color} | {color:red} The patch causes 26 errors with Hadoop v2.6.5. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 20s{color} | {color:red} The patch causes 26 errors with Hadoop v2.7.4. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 5s{color} | {color:red} The patch causes 26 errors with Hadoop v3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 12s{color} | {color:red} hbase-procedure generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 2m 21s{color} | {color:red} hbase-procedure in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 20s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.procedure2.store.wal.TestWALProcedureStore | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:6f01af0 | | JIRA Issue | HBASE-21354 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12944878/HBASE-21354.branch-2.0.001.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 948511c96a05 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-2.0 / 5908655244 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC3 | | mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/14777/artifact/patchprocess/patch-mvninstall-root.txt | | checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/14777/artifact/patchprocess/diff-checkstyle-hbase-procedure.txt | | shadedjars | https://builds.apache.org/job/PreCommit-HBASE-Build/14777/artifact/patchprocess/patch-shadedjars.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/14777/artifact/patchprocess/patch-javac-2.6.5.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/14777/artifact/patchprocess/patch-javac-2.7.4.txt | | hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/14777/artifact/patchprocess/patch-javac-3.0.0.txt | | javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/14777/artifact/patchprocess/diff-javadoc-javadoc-hbase-procedure.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/14777/artifact/patchprocess/patch-unit-hbase-procedure.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/14777/testReport/ | | Max. process+thread count | 101 (vs. ulimit of 10000) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/14777/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Procedure may be deleted improperly during master restarts resulting in > 'Corrupt' > --------------------------------------------------------------------------------- > > Key: HBASE-21354 > URL: https://issues.apache.org/jira/browse/HBASE-21354 > Project: HBase > Issue Type: Sub-task > Affects Versions: 2.1.0, 2.0.2 > Reporter: Allan Yang > Assignee: Allan Yang > Priority: Major > Attachments: HBASE-21354.branch-2.0.001.patch > > > Good news! [~stack], [~Apache9], I may find the root cause of mysterious > ‘Corrupted procedure’ or some procedures disappeared after master > restarts(happens during ITBLL). > This is because during master restarts, we load procedures from the log, and > builds the 'holdingCleanupTracker' according each log's tracker. We may mark > a procedure in the oldest log as deleted if one log doesn't contain the > procedure. This is Inappropriate since one log will not contain info of the > log if this procedure was not updated during the time. We can only delete the > procedure only if it is not in the global tracker, which have the whole > picture. > {code} > trackerNode = tracker.lookupClosestNode(trackerNode, procId); > if (trackerNode == null || !trackerNode.contains(procId) || > trackerNode.isModified(procId)) { > // the procedure was removed or modified > node.delete(procId); > } > {code} > A test case(testProcedureShouldNotCleanOnLoad) shows cleanly how the > corruption happened in the patch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)