[
https://issues.apache.org/jira/browse/HBASE-21322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664634#comment-16664634
]
stack commented on HBASE-21322:
-------------------------------
Thanks for the patch [~tianjingyun]. Looks better sir. One item to consider is
that you may be duplicating what
getServerNameFromWALDirectoryName#getServerNameFromWALDirectoryName does? Is
that possible?
If making a new patch, you might check if the Procedure is finished before
claiming one is running (it may not be running):
if (serverName.compareTo(((ServerCrashProcedure) procedure).getServerName()) ==
0) {
> Add a scheduleServerCrashProcedure() API to HbckService
> -------------------------------------------------------
>
> Key: HBASE-21322
> URL: https://issues.apache.org/jira/browse/HBASE-21322
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jingyun Tian
> Assignee: Jingyun Tian
> Priority: Major
> Attachments: HBASE-21322.master.001.patch,
> HBASE-21322.master.002.patch, HBASE-21322.master.003.patch, Screenshot from
> 2018-10-17 13-35-58.png, Screenshot from 2018-10-17 13-38-41.png, Screenshot
> from 2018-10-17 13-47-06.png
>
>
> According to my test, if one RS is down, then all procedure logs are deleted,
> it will lead to that no ServerCrashProcedure is scheduled. And restarting
> master cannot help. Thus we need to schedule a ServerCrashProcedure manually
> to solve the problem. I plan to add a scheduleServerCrashProcedure() API to
> HbckService, then add this API to HBCK2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
