[ 
https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666230#comment-16666230
 ] 

Hadoop QA commented on HBASE-21401:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
19s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
50s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
22s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
28s{color} | {color:red} hbase-common: The patch generated 6 new + 236 
unchanged - 1 fixed = 242 total (was 237) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
20s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
11m  7s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.7.4 or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 
49s{color} | {color:red} hbase-common generated 1 new + 0 unchanged - 0 fixed = 
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
38s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}246m 17s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
55s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}297m 39s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-common |
|  |  Bitwise OR of signed byte value computed in 
org.apache.hadoop.hbase.util.Bytes.readAsShort(byte[], int)   At 
Bytes.java:value computed in 
org.apache.hadoop.hbase.util.Bytes.readAsShort(byte[], int)   At 
Bytes.java:[line 1178] |
| Failed junit tests | hadoop.hbase.regionserver.TestMobStoreScanner |
|   | hadoop.hbase.replication.TestReplicationSyncUpTool |
|   | hadoop.hbase.TestMetaTableAccessor |
|   | hadoop.hbase.client.TestRestoreSnapshotFromClientClone |
|   | hadoop.hbase.master.procedure.TestTruncateTableProcedure |
|   | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay |
|   | hadoop.hbase.replication.TestNamespaceReplication |
|   | hadoop.hbase.replication.TestReplicationEmptyWALRecovery |
|   | 
hadoop.hbase.replication.regionserver.TestDrainReplicationQueuesForStandBy |
|   | hadoop.hbase.regionserver.TestNewVersionBehaviorFromClientSide |
|   | hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas |
|   | hadoop.hbase.regionserver.TestRegionReplicasWithModifyTable |
|   | hadoop.hbase.master.TestDLSAsyncFSWAL |
|   | hadoop.hbase.client.TestCloneSnapshotFromClientAfterSplittingRegion |
|   | hadoop.hbase.client.TestReplicasClient |
|   | hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk |
|   | hadoop.hbase.mob.TestMobDataBlockEncoding |
|   | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterTruncate |
|   | hadoop.hbase.master.procedure.TestServerCrashProcedureWithReplicas |
|   | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation |
|   | hadoop.hbase.wal.TestWALFactory |
|   | hadoop.hbase.client.TestRestoreSnapshotFromClientAfterSplittingRegions |
|   | hadoop.hbase.regionserver.wal.TestWALReplay |
|   | hadoop.hbase.util.TestMiniClusterLoadParallel |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService 
|
|   | hadoop.hbase.master.TestDLSFSHLog |
|   | hadoop.hbase.replication.regionserver.TestReplicationSource |
|   | hadoop.hbase.regionserver.TestTags |
|   | hadoop.hbase.util.TestMiniClusterLoadEncoded |
|   | hadoop.hbase.regionserver.TestHRegionReplayEvents |
|   | hadoop.hbase.util.TestMiniClusterLoadSequential |
|   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService |
|   | hadoop.hbase.replication.TestReplicationDroppedTables |
|   | hadoop.hbase.master.procedure.TestModifyTableProcedure |
|   | 
hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint |
|   | hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange |
|   | hadoop.hbase.replication.TestPerTableCFReplication |
|   | hadoop.hbase.master.TestMasterOperationsForRegionReplicas |
|   | hadoop.hbase.replication.TestMultiSlaveReplication |
|   | hadoop.hbase.regionserver.wal.TestAsyncWALReplay |
|   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21401 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12945922/HBASE-21401.v1.patch |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
shadedjars  hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux e8368d08cc29 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 
08:52:28 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 7cdb525192 |
| maven | version: Apache Maven 3.5.4 
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC3 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14886/artifact/patchprocess/diff-checkstyle-hbase-common.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14886/artifact/patchprocess/new-findbugs-hbase-common.html
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14886/artifact/patchprocess/patch-unit-hbase-server.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14886/testReport/ |
| Max. process+thread count | 5266 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/14886/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Sanity check in BaseDecoder#parseCell
> -------------------------------------
>
>                 Key: HBASE-21401
>                 URL: https://issues.apache.org/jira/browse/HBASE-21401
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>            Priority: Major
>             Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
>         Attachments: HBASE-21401.v1.patch
>
>
> In KeyValueDecoder & ByteBuffKeyValueDecoder,  we pass a byte buffer to 
> initialize the Cell without a sanity check (check each field's offset&len 
> exceed the byte buffer or not), so ArrayIndexOutOfBoundsException may happen 
> when read the cell's fields, such as HBASE-213,  it's hard to debug this kind 
> of bug. 
> An earlier check will help to find such kind of bugs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to