[ https://issues.apache.org/jira/browse/HBASE-21393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668949#comment-16668949 ]
stack commented on HBASE-21393: ------------------------------- I took a look at our Admin and HBaseAdmin implementation and at Table and HTable. They use our internal protobuf.... internally.... so it ok for you to do same. So, leave it. Our proto files are part of our For guava, we should say what version we want in local pom rather than rely on transitive include or depend on the internal hbase version by doing import org.apache.hbase.shaded.com.google.common.collect.Lists; Can do the guava dependency in a follow-on? Rather than this: private static final String SCHEDULE_SCP = "scheduleSCP"; ... perhaps do private static final String SCHEDULE_SCP = "serverCrashProcedures"; Make it plural like assigns and unassigns. In the help say something like below to explain 'SCP'. " Schedule serverCrashProcedure (SCP) for specified ServerName." ... then you can use SCP in the rest of the help text in place of serverCrashProcedures. Thanks [~tianjingyun] > Add an API ScheduleSCP() to HBCK2 > ---------------------------------- > > Key: HBASE-21393 > URL: https://issues.apache.org/jira/browse/HBASE-21393 > Project: HBase > Issue Type: Sub-task > Components: hbase-operator-tools, hbck2 > Reporter: Jingyun Tian > Assignee: Jingyun Tian > Priority: Major > Attachments: 0001-HBASE-21393-Add-an-API-ScheduleSCP-to-HBCK2.patch > > > Add the API of ScheduleSCP() to hbase-operator-tools so that operators can > schedule ServerCrashProcedures of specified regionservers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)