hbasejanitor commented on a change in pull request #3: HBASE-21002 make an
assembly for hbase-connectors
URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r229867217
##########
File path: kafka/hbase-kafka-proxy/pom.xml
##########
@@ -76,43 +77,40 @@
<dependency>
<groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId>
- </dependency>
+ </dependency>
<dependency>
<groupId>org.apache.hbase.connectors</groupId>
<artifactId>hbase-kafka-model</artifactId>
</dependency>
- <dependency>
- <groupId>org.apache.hbase</groupId>
- <artifactId>hbase-common</artifactId>
- </dependency>
+
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-common</artifactId>
<type>test-jar</type>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.apache.hbase</groupId>
- <artifactId>hbase-client</artifactId>
- </dependency>
- <dependency>
- <groupId>org.apache.hbase</groupId>
- <artifactId>hbase-zookeeper</artifactId>
- </dependency>
+
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-server</artifactId>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-annotations</artifactId>
+ <scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-annotations</artifactId>
<type>test-jar</type>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.yetus</groupId>
+ <artifactId>audience-annotations</artifactId>
+ <version>${audience-annotations.version}</version>
+ </dependency>
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
Review comment:
Sorry, I've been away from this patch for a while.
hbase-client isn't need at all, but hbase-server is. Without it, I don't
have access to the classes to start a region server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
