[ https://issues.apache.org/jira/browse/HBASE-5526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224958#comment-13224958 ]
jirapos...@reviews.apache.org commented on HBASE-5526: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4217/ ----------------------------------------------------------- (Updated 2012-03-08 02:55:22.079338) Review request for hbase and Lars Hofhansl. Changes ------- Updating review description and title Summary (updated) ------- Currently many all the files created by the HBase user are just written using the default file permissions granted by hdfs. However, to ensure only the correct user/group views the files and directories, we need to be able to apply a configurable umask to either directories or files. This ticket covers setting permissions for files written to dfs, as opposed to things like pid and log files. The impetus for this was to allow the web-user to view the directory structure of hbase, but not to actually see any of the actual data hbase is storing. This addresses bug HBASE-5526. https://issues.apache.org/jira/browse/HBASE-5526 Diffs ----- src/main/java/org/apache/hadoop/hbase/HConstants.java e60ce04 src/main/java/org/apache/hadoop/hbase/io/Reference.java 6360059 src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java 9e7e624 src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java c726603 src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 8a7da2e src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 76ff422 src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java 3f42efa src/main/java/org/apache/hadoop/hbase/regionserver/Store.java d884598 src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 12ebc0a src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java b5049b1 src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java 5c8fc5e src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac src/main/java/org/apache/hadoop/hbase/util/FSUtils.java d2d7efe src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 720841c src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java f6d088f src/main/java/org/apache/hadoop/hbase/zookeeper/ZKSplitLog.java 30d7fe9 src/main/resources/hbase-default.xml 9277e0c src/test/java/org/apache/hadoop/hbase/TestFSTableDescriptorForceCreation.java 6bc7c32 src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java a5628b9 src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java 5b3b962 src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java f1ea701 src/test/java/org/apache/hadoop/hbase/util/TestFSTableDescriptors.java 0db4d42 src/test/java/org/apache/hadoop/hbase/util/TestFSUtils.java e2611e6 Diff: https://reviews.apache.org/r/4217/diff Testing ------- "mvn clean test -P localTests" passes Thanks, Jesse > Configurable file and directory based umask > ------------------------------------------- > > Key: HBASE-5526 > URL: https://issues.apache.org/jira/browse/HBASE-5526 > Project: HBase > Issue Type: New Feature > Components: regionserver > Reporter: Jesse Yates > Assignee: Jesse Yates > Fix For: 0.94.0 > > Attachments: java_HBASE-5526-v2.patch, java_HBASE-5526-v3.patch, > java_HBASE-5526.patch > > > Currently many all the files created by the HBase user are just written using > the default file permissions granted by hdfs. However, to ensure only the > correct user/group views the files and directories, we need to be able to > apply a configurable umask to either directories or files. > This ticket covers setting permissions for files written to dfs, as opposed > to things like pid and log files. > The impetus for this was to allow the web-user to view the directory > structure of hbase, but not to actually see any of the actual data hbase is > storing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira