[ 
https://issues.apache.org/jira/browse/HBASE-5532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

terry zhang updated HBASE-5532:
-------------------------------

    Attachment: HBASE-5532-v2.patch

add a read lock during isMajorCompaction() to avoid race condition.
                
> get NPE during MajorCompactionChecker 
> --------------------------------------
>
>                 Key: HBASE-5532
>                 URL: https://issues.apache.org/jira/browse/HBASE-5532
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: terry zhang
>         Attachments: HBASE-5532-v2.patch, HBASE-5532.patch
>
>
> We found error log (NullPointerException) below on our online cluster:
> 2012-03-05 00:17:09,592 ERROR 
> org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: 
> Caught exception
> java.lang.NullPointerException
>         at 
> org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:878)
>         at 
> org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:857)
>         at 
> org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3017)
>         at 
> org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1172)
>         at org.apache.hadoop.hbase.Chore.run(Chore.java:66)
> After Check the code we found although it already check whether store files 
> has null reader at the begin of the function(isMajorCompaction), but it still 
> has some possibility the reader is closed before it return(eg mini 
> compaction). So we need to check store file reader before we use it to avoid 
> this NPE

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to