[
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672343#comment-16672343
]
Josh Elser commented on HBASE-21246:
------------------------------------
{quote}Unreadable. Conveys nothing but complexity
{quote}
Yeahhh, very chatty (expressed this offline, too). The "so-what" is missing.
I made the suggestion to Ted to start more high-level: show me the class-level
relationships between the "important" classes to start. For example: a
replication source constructs a WALEntryStream which has many WAL Reader
classes which are constructed from WALFactory which in turn calls WALProvider.
So, something like ReplicationSource -> WALEntryStream -> WAL.Reader ->
WALFactory -> WALProvider. This could be repeated for the other main consumers
(recovery, write-path).
My concern is that I'm "in the echo-chamber" and not giving something that is
helpful to the rest of you. Confirmation on the above would be helpful,
otherwise please give a concrete suggestion as to what would be better instead,
please and thank you.
{quote}Why as attachments to the issue and not integrated into design doc?
{quote}
My assumption was that they were presented here as a first draft, to be lifted
into design doc if/when sign-off that they are helpful was received.
> Introduce WALIdentity interface
> -------------------------------
>
> Key: HBASE-21246
> URL: https://issues.apache.org/jira/browse/HBASE-21246
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Fix For: HBASE-20952
>
> Attachments: 21246.003.patch, 21246.20.txt, 21246.21.txt,
> 21246.23.txt, 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch,
> 21246.HBASE-20952.004.patch, 21246.HBASE-20952.005.patch,
> 21246.HBASE-20952.007.patch, 21246.HBASE-20952.008.patch,
> wal-factory-providers.png, wal-providers.png
>
>
> We are introducing WALIdentity interface so that the WAL representation can
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent
> filename in distributed filesystem environment or, the name of the stream
> when the WAL is backed by log stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
