[ 
https://issues.apache.org/jira/browse/HBASE-21401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677776#comment-16677776
 ] 

Zheng Hu commented on HBASE-21401:
----------------------------------

I used the following cmd to make a benchmark: 

nohup ./bin/hbase pe --rows=10000 --nomapred sequentialWrite 100 > perf.log  
2>&1

|| Test Case || TotalMinTime|| TotalMaxTime || TotalAvgTime || AvgLantecy 
||AvgTPS/QPS || 
|Before Patch #1|  8977ms| 10589ms| 9807ms| 953us|102167|
|Before Patch #2|  7971ms| 12184ms| 10965ms| 972us|92200|
|After Patch#1| 9080ms | 11133ms|10236ms | 984us| 97880|
|After Patch#2| 9031ms | 10667ms|9955ms | 970us| 100638|

we can see that, no much diff between BeforePatch and AfterPatch case. 

FYI [~Apache9].


> Sanity check in BaseDecoder#parseCell
> -------------------------------------
>
>                 Key: HBASE-21401
>                 URL: https://issues.apache.org/jira/browse/HBASE-21401
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>            Priority: Critical
>             Fix For: 3.0.0, 2.2.0, 2.0.3, 2.1.2
>
>         Attachments: HBASE-21401.v1.patch, HBASE-21401.v2.patch, 
> HBASE-21401.v3.patch, HBASE-21401.v4.patch, HBASE-21401.v4.patch
>
>
> In KeyValueDecoder & ByteBuffKeyValueDecoder,  we pass a byte buffer to 
> initialize the Cell without a sanity check (check each field's offset&len 
> exceed the byte buffer or not), so ArrayIndexOutOfBoundsException may happen 
> when read the cell's fields, such as HBASE-21379,  it's hard to debug this 
> kind of bug. 
> An earlier check will help to find such kind of bugs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to