[ https://issues.apache.org/jira/browse/HBASE-21439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680590#comment-16680590 ]
Hudson commented on HBASE-21439: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-1.3-IT #501 (See [https://builds.apache.org/job/HBase-1.3-IT/501/]) HBASE-21439 RegionLoads aren't being used in RegionLoad cost functions (apurtell: rev 6618a40ffa89a402ccd781e52038fe7bd2ad14b2) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java > StochasticLoadBalancer RegionLoads aren’t being used in RegionLoad cost > functions > --------------------------------------------------------------------------------- > > Key: HBASE-21439 > URL: https://issues.apache.org/jira/browse/HBASE-21439 > Project: HBase > Issue Type: Bug > Components: Balancer > Affects Versions: 1.3.2.1, 2.0.2 > Reporter: Ben Lau > Assignee: Ben Lau > Priority: Major > Fix For: 3.0.0, 1.5.0, 1.3.3, 2.2.0, 2.0.3, 1.4.9, 2.1.2 > > Attachments: HBASE-21439-addendum-master.patch, > HBASE-21439-branch-1.patch, HBASE-21439-branch-1.patch, > HBASE-21439-master.patch > > > In StochasticLoadBalancer.updateRegionLoad() the region loads are being put > into the map with Bytes.toString(regionName). > First, this is a problem because Bytes.toString() assumes that the byte array > is a UTF8 encoded String but there is no guarantee that regionName bytes are > legal UTF8. > Secondly, in BaseLoadBalancer.registerRegion, we are reading the region loads > out of the load map not using Bytes.toString() but using > region.getRegionNameAsString() and region.getEncodedName(). So the load > balancer will not see or use any of the cluster's RegionLoad history. > There are 2 primary ways to solve this issue, assuming we want to stay with > String keys for the load map (seems reasonable to aid debugging). We can > either fix updateRegionLoad to store the regionName as a string properly or > we can update both the reader & writer to use a new common valid String > representation. > Will post a patch assuming we want to pursue the original intention, i.e. > store regionNameAsAString for the loadmap key, but I'm open to fixing this a > different way. -- This message was sent by Atlassian JIRA (v7.6.3#76005)